]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
WNM: Set wnm_reply to 0 when sending it
authorBenjamin Berg <benjamin.berg@intel.com>
Tue, 20 Feb 2024 13:18:24 +0000 (14:18 +0100)
committerJouni Malinen <j@w1.fi>
Sat, 2 Mar 2024 18:52:17 +0000 (20:52 +0200)
There is no point in the caller to set it to zero. Just do so within
wnm_send_bss_transition_mgmt_resp().

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
wpa_supplicant/wnm_sta.c

index cd2c2903da0ec4b475d9816d4b9fba807052c48a..8cc5559c9bf45a673f11e5212da525c6642b8464 100644 (file)
@@ -1032,6 +1032,8 @@ static int wnm_send_bss_transition_mgmt_resp(
        struct wpabuf *buf;
        int res;
 
+       wpa_s->wnm_reply = 0;
+
        wpa_printf(MSG_DEBUG,
                   "WNM: Send BSS Transition Management Response to " MACSTR
                   " dialog_token=%u status=%u reason=%u delay=%d",
@@ -1120,7 +1122,6 @@ static void wnm_bss_tm_connect(struct wpa_supplicant *wpa_s,
 
        /* Send the BSS Management Response - Accept */
        if (wpa_s->wnm_reply) {
-               wpa_s->wnm_reply = 0;
                wpa_s->wnm_target_bss = bss;
                wpa_printf(MSG_DEBUG,
                           "WNM: Sending successful BSS Transition Management Response");
@@ -1232,12 +1233,11 @@ int wnm_scan_process(struct wpa_supplicant *wpa_s, bool pre_scan_check)
 send_bss_resp_fail:
        /* Send reject response for all the failures */
 
-       if (wpa_s->wnm_reply) {
-               wpa_s->wnm_reply = 0;
+       if (wpa_s->wnm_reply)
                wnm_send_bss_transition_mgmt_resp(wpa_s,
                                                  wpa_s->wnm_dialog_token,
                                                  status, reason, 0, NULL);
-       }
+
        wnm_deallocate_memory(wpa_s);
 
        return 0;