]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
powercap: intel_rapl_tpmi: Remove FW_BUG from invalid version check
authorKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Wed, 11 Feb 2026 22:34:01 +0000 (14:34 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 12 Feb 2026 13:49:14 +0000 (14:49 +0100)
On partitioned systems, multiple TPMI instances may exist per package,
but RAPL registers are only valid on one instance since RAPL has
package-scope control. Other instances return invalid versions during
domain parsing, which is expected behavior on such systems.

Currently this generates a firmware bug warning:

  intel_rapl_tpmi: [Firmware Bug]: Invalid version

Remove the FW_BUG tag, downgrade to pr_debug(), and update the message
to clarify that invalid versions are expected on partitioned systems
where only one instance can be valid.

Fixes: 9eef7f9da928 ("powercap: intel_rapl: Introduce RAPL TPMI interface driver")
Reported-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20260211223401.1575776-1-sathyanarayanan.kuppuswamy@linux.intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/powercap/intel_rapl_tpmi.c

index 0a0b85f4528b1b2e901b66f7ea7c43eae282fb6b..0f8abdc592bc19b7b6ab46b0c271af346071abff 100644 (file)
@@ -157,7 +157,7 @@ static int parse_one_domain(struct tpmi_rapl_package *trp, u32 offset)
        tpmi_domain_flags = tpmi_domain_header >> 32 & 0xffff;
 
        if (tpmi_domain_version == TPMI_VERSION_INVALID) {
-               pr_warn(FW_BUG "Invalid version\n");
+               pr_debug("Invalid version, other instances may be valid\n");
                return -ENODEV;
        }