smb: smbdirect: introduce smbdirect_connection_send_io_done()

This is a combination of send_done() of client and server.
It will replace both...

Cc: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Long Li <longli@microsoft.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/common/smbdirect/smbdirect_connection.c b/fs/smb/common/smbdirect/smbdirect_connection.c
index 0b35840ad4f20827590bcd2ef86ec3bec3b66342..573dc278ca71826b9b69edd4817e5a79b9da6d74 100644 (file)
--- a/fs/smb/common/smbdirect/smbdirect_connection.c
+++ b/fs/smb/common/smbdirect/smbdirect_connection.c
@@ -160,3 +160,73 @@ static void smbdirect_connection_idle_timer_work(struct work_struct *work)
                "schedule send of empty idle message\n");
        queue_work(sc->workqueue, &sc->idle.immediate_work);
 }
+
+__maybe_unused /* this is temporary while this file is included in others */
+static void smbdirect_connection_send_io_done(struct ib_cq *cq, struct ib_wc *wc)
+{
+       struct smbdirect_send_io *msg =
+               container_of(wc->wr_cqe, struct smbdirect_send_io, cqe);
+       struct smbdirect_socket *sc = msg->socket;
+       struct smbdirect_send_io *sibling, *next;
+       int lcredits = 0;
+
+       smbdirect_log_rdma_send(sc, SMBDIRECT_LOG_INFO,
+               "smbdirect_send_io completed. status='%s (%d)', opcode=%d\n",
+               ib_wc_status_msg(wc->status), wc->status, wc->opcode);
+
+       if (unlikely(!(msg->wr.send_flags & IB_SEND_SIGNALED))) {
+               /*
+                * This happens when smbdirect_send_io is a sibling
+                * before the final message, it is signaled on
+                * error anyway, so we need to skip
+                * smbdirect_connection_free_send_io here,
+                * otherwise is will destroy the memory
+                * of the siblings too, which will cause
+                * use after free problems for the others
+                * triggered from ib_drain_qp().
+                */
+               if (wc->status != IB_WC_SUCCESS)
+                       goto skip_free;
+
+               /*
+                * This should not happen!
+                * But we better just close the
+                * connection...
+                */
+               smbdirect_log_rdma_send(sc, SMBDIRECT_LOG_ERR,
+                       "unexpected send completion wc->status=%s (%d) wc->opcode=%d\n",
+                       ib_wc_status_msg(wc->status), wc->status, wc->opcode);
+               smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
+               return;
+       }
+
+       /*
+        * Free possible siblings and then the main send_io
+        */
+       list_for_each_entry_safe(sibling, next, &msg->sibling_list, sibling_list) {
+               list_del_init(&sibling->sibling_list);
+               smbdirect_connection_free_send_io(sibling);
+               lcredits += 1;
+       }
+       /* Note this frees wc->wr_cqe, but not wc */
+       smbdirect_connection_free_send_io(msg);
+       lcredits += 1;
+
+       if (unlikely(wc->status != IB_WC_SUCCESS || WARN_ON_ONCE(wc->opcode != IB_WC_SEND))) {
+skip_free:
+               if (wc->status != IB_WC_WR_FLUSH_ERR)
+                       smbdirect_log_rdma_send(sc, SMBDIRECT_LOG_ERR,
+                               "wc->status=%s (%d) wc->opcode=%d\n",
+                               ib_wc_status_msg(wc->status), wc->status, wc->opcode);
+               smbdirect_socket_schedule_cleanup(sc, -ECONNABORTED);
+               return;
+       }
+
+       atomic_add(lcredits, &sc->send_io.lcredits.count);
+       wake_up(&sc->send_io.lcredits.wait_queue);
+
+       if (atomic_dec_and_test(&sc->send_io.pending.count))
+               wake_up(&sc->send_io.pending.zero_wait_queue);
+
+       wake_up(&sc->send_io.pending.dec_wait_queue);
+}