]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
rdma: stat: fix return code
authorAndrea Claudi <aclaudi@redhat.com>
Sun, 18 Apr 2021 12:56:30 +0000 (14:56 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Wed, 21 Apr 2021 01:08:38 +0000 (18:08 -0700)
libmnl defines MNL_CB_OK as 1 and MNL_CB_ERROR as -1. rdma uses these
return codes, and stat_qp_show_parse_cb() should do the same.

Fixes: 16ce4d23661a ("rdma: stat: initialize ret in stat_qp_show_parse_cb()")
Reported-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Acked-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
rdma/stat.c

index 3abedae74534d0dc4186ea974f842dd835481c6e..8edf7bf1c3747d53145bf1c3235a1fa69063c401 100644 (file)
@@ -307,7 +307,7 @@ static int stat_qp_show_parse_cb(const struct nlmsghdr *nlh, void *data)
        struct rd *rd = data;
        const char *name;
        uint32_t idx;
-       int ret = 0;
+       int ret = MNL_CB_OK;
 
        mnl_attr_parse(nlh, 0, rd_attr_cb, tb);
        if (!tb[RDMA_NLDEV_ATTR_DEV_INDEX] || !tb[RDMA_NLDEV_ATTR_DEV_NAME] ||