Backing out bug 238780 (Edit versions should reject newline characters) - This patch...

diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm
index 31a1052e43b03217b9b92426d845c93535f1d833..21885bbdc8f56fb0ca6b2e168394ef163b1b8e74 100644 (file)
--- a/Bugzilla/Util.pm
+++ b/Bugzilla/Util.pm
@@ -42,7 +42,7 @@ use base qw(Exporter);
                              format_time format_time_decimal validate_date
                              file_mod_time is_7bit_clean
                              bz_crypt generate_random_password
-                             validate_email_syntax clean_text);
+                             validate_email_syntax);
 
 use Bugzilla::Config;
 use Bugzilla::Constants;
@@ -390,12 +390,6 @@ sub is_7bit_clean {
     return $_[0] !~ /[^\x20-\x7E\x0A\x0D]/;
 }
 
-sub clean_text {
-    my ($dtext) = shift;
-    $dtext =~  s/[\x00-\x1F\x7F]/ /g;   # change control characters to spaces
-    return $dtext;
-}
-
 1;
 
 __END__
@@ -645,10 +639,6 @@ into the string.
 Returns true is the string contains only 7-bit characters (ASCII 32 through 126,
 ASCII 10 (LineFeed) and ASCII 13 (Carrage Return).
 
-=item C<clean_text($str)>
-Returns the parameter "cleaned" by exchanging non-printable characters with spaces.
-Specifically characters (ASCII 0 through 31) and (ASCII 127) will become ASCII 32 (Space).
-
 =back
 
 =head2 Formatting Time

diff --git a/editversions.cgi b/editversions.cgi
index be2c8a3c6e0489cf61f20942a234ab82831d6699..43816e6aaa47379dd78eb862eb9e9ed5de69f693 100755 (executable)
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -130,9 +130,6 @@ if ($action eq 'new') {
     # Cleanups and valididy checks
     $version_name || ThrowUserError('version_blank_name');
 
-    # Remove unprintable characters
-    $version_name = clean_text($version_name);
-
     my $version = new Bugzilla::Version($product->id, $version_name);
     if ($version) {
         ThrowUserError('version_already_exists',
@@ -245,10 +242,6 @@ if ($action eq 'edit') {
 if ($action eq 'update') {
 
     $version_name || ThrowUserError('version_not_specified');
-
-    # Remove unprintable characters
-    $version_name = clean_text($version_name);
-
     my $version_old_name = trim($cgi->param('versionold') || '');
     my $version_old =
         Bugzilla::Version::check_version($product,