]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/boot: Fix simpleboot CPU node lookup check
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 2 Jul 2026 21:15:55 +0000 (23:15 +0200)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Tue, 28 Jul 2026 04:53:31 +0000 (10:23 +0530)
fdt_node_offset_by_prop_value() returns a negative error code on
failure - fix the check accordingly.

Fixes: d2477b5cc8ca ("[POWERPC] bootwrapper: Add a firmware-independent simpleboot target.")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20260702211554.56923-4-thorsten.blum@linux.dev
arch/powerpc/boot/simpleboot.c

index c80691d83880b8856e7814ad983589c47b62b172..27591df41e9e842b167f955524ca5bb85d67ebcd 100644 (file)
@@ -68,7 +68,7 @@ void platform_init(unsigned long r3, unsigned long r4, unsigned long r5,
        /* finally, setup the timebase */
        node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type",
                                             "cpu", sizeof("cpu"));
-       if (!node)
+       if (node < 0)
                fatal("Cannot find cpu node\n");
        timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size);
        if (timebase && (size == 4))