]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix memory leak in logging setup
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 1 Dec 2010 16:42:17 +0000 (16:42 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 2 Dec 2010 12:16:24 +0000 (12:16 +0000)
The logging setup requires const char * strings, but the
virLogSetFromEnv() strdup's the env variables, thus causing
a memory leak

* src/util/logging.c: Avoid strdup'ing env variables

src/util/logging.c

index d65dec077c7f6b7278fd7bb6b6a4e3cece215530..83cc358c084e1044297c41e83c67e20117d3c790 100644 (file)
@@ -980,8 +980,8 @@ void virLogSetFromEnv(void) {
         virLogParseDefaultPriority(debugEnv);
     debugEnv = getenv("LIBVIRT_LOG_FILTERS");
     if (debugEnv && *debugEnv)
-        virLogParseFilters(strdup(debugEnv));
+        virLogParseFilters(debugEnv);
     debugEnv = getenv("LIBVIRT_LOG_OUTPUTS");
     if (debugEnv && *debugEnv)
-        virLogParseOutputs(strdup(debugEnv));
+        virLogParseOutputs(debugEnv);
 }