tc: flower: Add missing err check when parsing flower options

addattr32 may return an error.

Fixes: cfcabf18d84a ("tc: flower: Add skip_{hw|sw} support")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>

diff --git a/tc/f_flower.c b/tc/f_flower.c
index 1dbc5320f14f71abb3a85b04c9ba5b284d17eed6..1272a471a84296fc7de6b004dddc11832b071913 100644 (file)
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -525,7 +525,9 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
        }
 
 parse_done:
-       addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags);
+       ret = addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags);
+       if (ret)
+               return ret;
 
        ret = addattr16(n, MAX_MSG, TCA_FLOWER_KEY_ETH_TYPE, eth_type);
        if (ret) {