]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86-64: Require BMI2 for AVX2 (raw|w)memchr implementations
authorAurelien Jarno <aurelien@aurel32.net>
Mon, 3 Oct 2022 21:16:46 +0000 (23:16 +0200)
committerAurelien Jarno <aurelien@aurel32.net>
Mon, 3 Oct 2022 21:53:23 +0000 (23:53 +0200)
The AVX2 memchr, rawmemchr and wmemchr implementations use the 'bzhi'
and 'sarx' instructions, which belongs to the BMI2 CPU feature.

Fixes: acfd088a1963 ("x86: Optimize memchr-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
(cherry picked from commit e3e7fab7fe5186d18ca2046d99ba321c27db30ad)

sysdeps/x86_64/multiarch/ifunc-impl-list.c

index 5824554b4edc58e585b121cbe737bfe7ef720aa0..9959f7b2286bef2413a16205365841f61cfbbc47 100644 (file)
@@ -59,10 +59,12 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
   /* Support sysdeps/x86_64/multiarch/memchr.c.  */
   IFUNC_IMPL (i, name, memchr,
              IFUNC_IMPL_ADD (array, i, memchr,
-                             CPU_FEATURE_USABLE (AVX2),
+                             (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)),
                              __memchr_avx2)
              IFUNC_IMPL_ADD (array, i, memchr,
                              (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)
                               && CPU_FEATURE_USABLE (RTM)),
                              __memchr_avx2_rtm)
              IFUNC_IMPL_ADD (array, i, memchr,
@@ -301,10 +303,12 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
   /* Support sysdeps/x86_64/multiarch/rawmemchr.c.  */
   IFUNC_IMPL (i, name, rawmemchr,
              IFUNC_IMPL_ADD (array, i, rawmemchr,
-                             CPU_FEATURE_USABLE (AVX2),
+                             (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)),
                              __rawmemchr_avx2)
              IFUNC_IMPL_ADD (array, i, rawmemchr,
                              (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)
                               && CPU_FEATURE_USABLE (RTM)),
                              __rawmemchr_avx2_rtm)
              IFUNC_IMPL_ADD (array, i, rawmemchr,
@@ -805,10 +809,12 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
   /* Support sysdeps/x86_64/multiarch/wmemchr.c.  */
   IFUNC_IMPL (i, name, wmemchr,
              IFUNC_IMPL_ADD (array, i, wmemchr,
-                             CPU_FEATURE_USABLE (AVX2),
+                             (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)),
                              __wmemchr_avx2)
              IFUNC_IMPL_ADD (array, i, wmemchr,
                              (CPU_FEATURE_USABLE (AVX2)
+                              && CPU_FEATURE_USABLE (BMI2)
                               && CPU_FEATURE_USABLE (RTM)),
                              __wmemchr_avx2_rtm)
              IFUNC_IMPL_ADD (array, i, wmemchr,