]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWN...
authorJiri Kosina <jkosina@suse.com>
Wed, 12 Mar 2025 08:08:22 +0000 (09:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:31:58 +0000 (14:31 +0200)
[ Upstream commit fe0fb58325e519008e2606a5aa2cff7ad23e212d ]

The line

obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/

in top-level HID Makefile is both superfluous (as CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/ already) and wrong (as it's
missing the CONFIG_ prefix).

Just remove it.

Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client driver")
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/Makefile

index e29efcb1c0402c1a0b4280e86a8902941b32ecf3..9fc46db0a3da6702bfbe823c32a30d781be8750b 100644 (file)
@@ -144,7 +144,6 @@ obj-$(CONFIG_USB_KBD)               += usbhid/
 obj-$(CONFIG_I2C_HID_CORE)     += i2c-hid/
 
 obj-$(CONFIG_INTEL_ISH_HID)    += intel-ish-hid/
-obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/
 
 obj-$(CONFIG_AMD_SFH_HID)       += amd-sfh-hid/