Add constructore/destructor for Mgr::ActionPasswordList

Missing constructor for Mgr::ActionPasswordList resulted in invalid values
for next pointer and segmentation fault parsing multiple cachemgr_passwd
directives.

Missing destructor resulted in memory leaks on reconfigure and shutdown.

diff --git a/src/mgr/ActionPasswordList.cc b/src/mgr/ActionPasswordList.cc
index b480a4a80bdeafe9995ea2d94a501b44f1513454..5c34a0fb6647044a59c1a2c5ff711a86ac36b4af 100644 (file)
--- a/src/mgr/ActionPasswordList.cc
+++ b/src/mgr/ActionPasswordList.cc
@@ -29,4 +29,11 @@
 
 #include "squid.h"
 #include "mgr/ActionPasswordList.h"
+#include "wordlist.h"
 
+Mgr::ActionPasswordList::~ActionPasswordList()
+{
+    safe_free(passwd);
+    wordlistDestroy(&actions);
+    delete next;
+}

diff --git a/src/mgr/ActionPasswordList.h b/src/mgr/ActionPasswordList.h
index eba5a4335ff127fd9176b31b9a334a29d9ed3223..3e3ade7eee64227bacefcff316dac2b85cad8c3a 100644 (file)
--- a/src/mgr/ActionPasswordList.h
+++ b/src/mgr/ActionPasswordList.h
@@ -38,6 +38,9 @@ namespace Mgr
 class ActionPasswordList
 {
 public:
+    ActionPasswordList() : passwd(NULL), actions(NULL), next(NULL) {}
+    ~ActionPasswordList();
+
     char *passwd;
     wordlist *actions;
     ActionPasswordList *next;