s4:kdc: let samba_kdc_entry_pac[_from_trusted]() assert krbtgt is valid if pac is...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 7e680a425922d8a2e562cda6bdd0a8d09fbd4004..6eec1fc86d1e4be500558f22643f79f34180fa66 100644 (file)
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -879,6 +879,10 @@ struct samba_kdc_entry_pac samba_kdc_entry_pac(krb5_const_pac pac,
                                               struct samba_kdc_entry *entry,
                                               const struct samba_kdc_entry *krbtgt)
 {
+       if (pac != NULL) {
+               SMB_ASSERT(krbtgt != NULL);
+       }
+
        return (struct samba_kdc_entry_pac) {
                .entry = entry,
                .krbtgt = krbtgt,
@@ -891,6 +895,10 @@ struct samba_kdc_entry_pac samba_kdc_entry_pac_from_trusted(krb5_const_pac pac,
                                                            const struct samba_kdc_entry *krbtgt,
                                                            bool is_trusted)
 {
+       if (pac != NULL) {
+               SMB_ASSERT(krbtgt != NULL);
+       }
+
        return (struct samba_kdc_entry_pac) {
                .entry = entry,
                .krbtgt = krbtgt,