msgfmt: Fix potential access to uninitialized value

* msgfmt.c (msgfmt_desktop_bulk): Don't dereference potentially
uninitialized value.  Spotted by clang-analyzer.

diff --git a/gettext-tools/src/ChangeLog b/gettext-tools/src/ChangeLog
index 55b4ce81b67d1d239c5470eea11457e6c6c7f8be..926e5abc38cdb68b64558ef519f6969f737edffe 100644 (file)
--- a/gettext-tools/src/ChangeLog
+++ b/gettext-tools/src/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-09  Daiki Ueno  <ueno@gnu.org>
+
+       * msgfmt.c (msgfmt_desktop_bulk): Don't dereference potentially
+       uninitialized value.  Spotted by clang-analyzer.
+
 2014-12-09  Daiki Ueno  <ueno@gnu.org>
 
        * x-vala.c (phase3_get): Factor out the buffer allocation as a

diff --git a/gettext-tools/src/msgfmt.c b/gettext-tools/src/msgfmt.c
index 99026bfbd2bb7d277a0b7a43546d6cdc87611e36..3fabd8773e6000135132a97ef4bb65f3f7221de1 100644 (file)
--- a/gettext-tools/src/msgfmt.c
+++ b/gettext-tools/src/msgfmt.c
@@ -1392,10 +1392,7 @@ msgfmt_desktop_bulk (const char *directory,
 
   languages = get_languages (directory);
   if (!languages)
-    {
-      retval = EXIT_FAILURE;
-      goto out;
-    }
+    return EXIT_FAILURE;
 
   /* Reset the directory search list so only .po files under DIRECTORY
      will be read.  */