USB: xhci-plat: fix legacy PHY double init

[ Upstream commit 16b7e0cccb243033de4406ffb4d892365041a1e7 ]

Commits 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") and
9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support") added support
for looking up legacy PHYs from the sysdev devicetree node and
initialising them.

This broke drivers such as dwc3 which manages PHYs themself as the PHYs
would now be initialised twice, something which specifically can lead to
resources being left enabled during suspend (e.g. with the
usb_phy_generic PHY driver).

As the dwc3 driver uses driver-name matching for the xhci platform
device, fix this by only looking up and initialising PHYs for devices
that have been matched using OF.

Note that checking that the platform device has a devicetree node would
currently be sufficient, but that could lead to subtle breakages in case
anyone ever tries to reuse an ancestor's node.

Fixes: 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support")
Fixes: 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support")
Cc: stable@vger.kernel.org      # 4.1
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Stanley Chang <stanley_chang@realtek.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Tested-by: Stanley Chang <stanley_chang@realtek.com>
Link: https://lore.kernel.org/r/20231103164323.14294-1-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index c9a101f0e8d01b39796be01f0dff6689e47970b2..c9438dc56f5fcb01d5645055bb83770fa5cbe833 100644 (file)
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -184,7 +184,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
        int                     ret;
        int                     irq;
        struct xhci_plat_priv   *priv = NULL;
-
+       bool                    of_match;
 
        if (usb_disabled())
                return -ENODEV;
@@ -305,16 +305,23 @@ static int xhci_plat_probe(struct platform_device *pdev)
                                         &xhci->imod_interval);
        }
 
-       hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0);
-       if (IS_ERR(hcd->usb_phy)) {
-               ret = PTR_ERR(hcd->usb_phy);
-               if (ret == -EPROBE_DEFER)
-                       goto disable_clk;
-               hcd->usb_phy = NULL;
-       } else {
-               ret = usb_phy_init(hcd->usb_phy);
-               if (ret)
-                       goto disable_clk;
+       /*
+        * Drivers such as dwc3 manages PHYs themself (and rely on driver name
+        * matching for the xhci platform device).
+        */
+       of_match = of_match_device(pdev->dev.driver->of_match_table, &pdev->dev);
+       if (of_match) {
+               hcd->usb_phy = devm_usb_get_phy_by_phandle(sysdev, "usb-phy", 0);
+               if (IS_ERR(hcd->usb_phy)) {
+                       ret = PTR_ERR(hcd->usb_phy);
+                       if (ret == -EPROBE_DEFER)
+                               goto disable_clk;
+                       hcd->usb_phy = NULL;
+               } else {
+                       ret = usb_phy_init(hcd->usb_phy);
+                       if (ret)
+                               goto disable_clk;
+               }
        }
 
        hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);