]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
lib/crypto: md5: Use rol32() instead of open-coding it
authorRusydi H. Makarim <rusydi.makarim@kriptograf.id>
Sun, 14 Dec 2025 11:15:12 +0000 (18:15 +0700)
committerEric Biggers <ebiggers@kernel.org>
Mon, 12 Jan 2026 19:07:50 +0000 (11:07 -0800)
For the bitwise left rotation in MD5STEP, use rol32() from
<linux/bitops.h> instead of open-coding it.

Signed-off-by: Rusydi H. Makarim <rusydi.makarim@kriptograf.id>
Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
lib/crypto/md5.c

index c0610ea1370e62862fa17ad7b7bd7bba1911055d..c4af57db0ea830858b431db2ce1f56ae940b8b71 100644 (file)
@@ -29,7 +29,7 @@ static const struct md5_block_state md5_iv = {
 #define F4(x, y, z) (y ^ (x | ~z))
 
 #define MD5STEP(f, w, x, y, z, in, s) \
-       (w += f(x, y, z) + in, w = (w << s | w >> (32 - s)) + x)
+       (w += f(x, y, z) + in, w = rol32(w, s) + x)
 
 static void md5_block_generic(struct md5_block_state *state,
                              const u8 data[MD5_BLOCK_SIZE])