]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: ad7606: fix standby gpio state to match the documentation
authorGuillaume Stols <gstols@baylibre.com>
Tue, 2 Jul 2024 17:34:11 +0000 (17:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:33:17 +0000 (16:33 +0200)
[ Upstream commit 059fe4f8bbdf5cad212e1aeeb3e8968c80b9ff3b ]

The binding's documentation specifies that "As the line is active low, it
should be marked GPIO_ACTIVE_LOW". However, in the driver, it was handled
the opposite way. This commit sets the driver's behaviour in sync with the
documentation

Fixes: 722407a4e8c0 ("staging:iio:ad7606: Use GPIO descriptor API")
Signed-off-by: Guillaume Stols <gstols@baylibre.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/adc/ad7606.c

index 8c66b1e36401459810dd4ae380b2316a91711aac..4d755ffc3f4148d01d9181eaee0aad5e755f587d 100644 (file)
@@ -422,7 +422,7 @@ static int ad7606_request_gpios(struct ad7606_state *st)
                return PTR_ERR(st->gpio_range);
 
        st->gpio_standby = devm_gpiod_get_optional(dev, "standby",
-                                                  GPIOD_OUT_HIGH);
+                                                  GPIOD_OUT_LOW);
        if (IS_ERR(st->gpio_standby))
                return PTR_ERR(st->gpio_standby);
 
@@ -665,7 +665,7 @@ static int ad7606_suspend(struct device *dev)
 
        if (st->gpio_standby) {
                gpiod_set_value(st->gpio_range, 1);
-               gpiod_set_value(st->gpio_standby, 0);
+               gpiod_set_value(st->gpio_standby, 1);
        }
 
        return 0;