Allow aux_cache_file open()ing to fail silently even in the chroot mode.

The aux_cache fix of bug 11149 introduced a new bug - normally,
ldconfig -r never cares if the auxiliary cache is not available and
that is not a fatal problem, however this is not the case in case
of ldconfig -r when executed as non-root. In that case, ldconfig -r
fails hard unless var/cache/ldconfig/ exists within the chroot. This
patch fixes that.

diff --git a/ChangeLog b/ChangeLog
index 8f7372ba62dfc787045f0bb1abdfea8896e12f09..c7174be1062854577cf7c1645539ed93e78e79a7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-31  Petr Baudis  <pasky@suse.cz>
+
+       [BZ #11149]
+       * elf/ldconfig.c (main): Allow aux_cache_file open()ing to fail
+       silently even in the chroot mode.
+
 2010-08-19  Petr Baudis <pasky@suse.cz>
 
        [BZ #11928]

diff --git a/elf/ldconfig.c b/elf/ldconfig.c
index b4af31e5b52285dd99a8a18c48d879ac21577a22..b82ca8e308e8afbc00b322e902405c7e91d13fb4 100644 (file)
--- a/elf/ldconfig.c
+++ b/elf/ldconfig.c
@@ -1359,14 +1359,9 @@ main (int argc, char **argv)
 
   const char *aux_cache_file = _PATH_LDCONFIG_AUX_CACHE;
   if (opt_chroot)
-    {
-      aux_cache_file = chroot_canon (opt_chroot, aux_cache_file);
-      if (aux_cache_file == NULL)
-       error (EXIT_FAILURE, errno, _("Can't open cache file %s\n"),
-              _PATH_LDCONFIG_AUX_CACHE);
-    }
+    aux_cache_file = chroot_canon (opt_chroot, aux_cache_file);
 
-  if (! opt_ignore_aux_cache)
+  if (! opt_ignore_aux_cache && aux_cache_file)
     load_aux_cache (aux_cache_file);
   else
     init_aux_cache ();
@@ -1376,7 +1371,8 @@ main (int argc, char **argv)
   if (opt_build_cache)
     {
       save_cache (cache_file);
-      save_aux_cache (aux_cache_file);
+      if (aux_cache_file)
+        save_aux_cache (aux_cache_file);
     }
 
   return 0;