rbtdb: cleanup_dead_nodes should ignore alive nodes on the deadlist

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index 87fbdb317b93bb33be021d880e7a042eaa9ccc59..c0b3479684137f557f6888504608f843be8d378e 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -1914,15 +1914,16 @@ cleanup_dead_nodes(dns_rbtdb_t *rbtdb, int bucketnum) {
                ISC_LIST_UNLINK(rbtdb->deadnodes[bucketnum], node, deadlink);
 
                /*
-                * Since we're holding a tree write lock, it should be
-                * impossible for this node to be referenced by others.
-                *
-                * decrement_reference may not have tested node->down, as
-                * the tree_lock was not held, before adding the node to
-                * deadnodes so we test it here.
+                * We might have reactivated this node without a tree write
+                * lock, so we couldn't remove this node from deadnodes then
+                * and we have to do it now.
                 */
-               INSIST(isc_refcount_current(&node->references) == 0 &&
-                      node->data == NULL);
+               if (isc_refcount_current(&node->references) != 0 ||
+                   node->data != NULL) {
+                       node = ISC_LIST_HEAD(rbtdb->deadnodes[bucketnum]);
+                       count--;
+                       continue;
+               }
 
                if (is_leaf(node) && rbtdb->task != NULL) {
                        send_to_prune_tree(rbtdb, node, isc_rwlocktype_write);