]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: usb-audio: fix control pipe direction
authorRoy Vegard Ovesen <roy.vegard.ovesen@gmail.com>
Sat, 18 Oct 2025 17:18:22 +0000 (19:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:33:56 +0000 (15:33 -0500)
[ Upstream commit 7963891f7c9c6f759cc9ab7da71406b4234f3dd6 ]

Since the requesttype has USB_DIR_OUT the pipe should be
constructed with usb_sndctrlpipe().

Fixes: 8dc5efe3d17c ("ALSA: usb-audio: Add support for Presonus Studio 1810c")
Signed-off-by: Roy Vegard Ovesen <roy.vegard.ovesen@gmail.com>
Link: https://patch.msgid.link/aPPL3tBFE_oU-JHv@ark
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/mixer_s1810c.c

index fac4bbc6b275772dd27fecb8be0be987558e0c22..65bdda0841048026b401f3a8bb5f9b0ba57d3da0 100644 (file)
@@ -181,7 +181,7 @@ snd_sc1810c_get_status_field(struct usb_device *dev,
 
        pkt_out.fields[SC1810C_STATE_F1_IDX] = SC1810C_SET_STATE_F1;
        pkt_out.fields[SC1810C_STATE_F2_IDX] = SC1810C_SET_STATE_F2;
-       ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0),
+       ret = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0),
                              SC1810C_SET_STATE_REQ,
                              SC1810C_SET_STATE_REQTYPE,
                              (*seqnum), 0, &pkt_out, sizeof(pkt_out));