]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
.github: Suppress cherry-pick reminder for some situations
authorGeorge Joseph <gjoseph@sangoma.com>
Tue, 11 Jul 2023 12:31:04 +0000 (06:31 -0600)
committerGeorge Joseph <gjoseph@sangoma.com>
Tue, 11 Jul 2023 12:50:32 +0000 (06:50 -0600)
In PROpenedOrUpdated, the cherry-pick reminder will now be
suppressed if there are already valid 'cherry-pick-to' comments
in the PR or the PR contained a 'cherry-pick-to: none' comment.

.github/workflows/PROpenedOrUpdated.yml

index e75766a791f05b74ba89bd5a72ad287cde15c859..82c905410ddd23a5503975c81fea2d72628a5a8f 100644 (file)
@@ -27,19 +27,23 @@ jobs:
           application_private_key: ${{secrets.ASTERISK_ORG_ACCESS_APP_PRIV_KEY}}
           organization: asterisk
 
-      - name: Add cherry-pick reminder and reviewers
-        if: github.event.action == 'opened'
+      - name: Get cherry-pick branches
+        uses: asterisk/asterisk-ci-actions/GetCherryPickBranchesFromPR@main
+        id: getbranches
+        with:
+          repo:                    ${{github.repository}}
+          pr_number:               ${{env.PR_NUMBER}}
+          cherry_pick_regex:       ${{vars.CHERRY_PICK_REGEX}}
+          github_token:            ${{secrets.GITHUB_TOKEN}}
+
+      - name: Add cherry-pick reminder
+        if: ${{ steps.getbranches.outputs.branch_count == 0 || steps.getbranches.outputs.forced_none != 'true' }}
         env:
           GITHUB_TOKEN: ${{steps.get_workflow_token.outputs.token}}
           GH_TOKEN: ${{steps.get_workflow_token.outputs.token}}
           CHERRY_PICK_REMINDER: ${{vars.CHERRY_PICK_REMINDER}}
-          REVIEWERS: ${{vars.PR_REVIEWERS}}
         run: |
           IFS=$'; \n'
-          for r in $REVIEWERS ; do
-            echo "Adding reviewer $r"
-            gh pr edit --repo ${{github.repository}} ${PR_NUMBER} --add-reviewer $r || :
-          done
           # If there's already a reminder comment, don't add another one.
           ADD_COMMENT=true
           # This query will FAIL if it finds the comment.
@@ -54,6 +58,20 @@ jobs:
             echo "CPR comment already present"
           fi
 
+      - name: Add reviewers
+        if: github.event.action == 'opened'
+        env:
+          GITHUB_TOKEN: ${{steps.get_workflow_token.outputs.token}}
+          GH_TOKEN: ${{steps.get_workflow_token.outputs.token}}
+          CHERRY_PICK_REMINDER: ${{vars.CHERRY_PICK_REMINDER}}
+          REVIEWERS: ${{vars.PR_REVIEWERS}}
+        run: |
+          IFS=$'; \n'
+          for r in $REVIEWERS ; do
+            echo "Adding reviewer $r"
+            gh pr edit --repo ${{github.repository}} ${PR_NUMBER} --add-reviewer $r || :
+          done
+
       - name: Set Labels
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}