]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: ti: k3-socinfo: Fix regmap leak on probe failure
authorJohan Hovold <johan@kernel.org>
Thu, 27 Nov 2025 13:49:42 +0000 (14:49 +0100)
committerNishanth Menon <nm@ti.com>
Wed, 14 Jan 2026 16:58:48 +0000 (10:58 -0600)
The mmio regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org # 6.15
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20251127134942.2121-1-johan@kernel.org
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/soc/ti/k3-socinfo.c

index 50c170a995f90bb7d153f7a54c9d321de783622b..42275cb5ba1c8dfe0deffe5202d6ebe0d79039d0 100644 (file)
@@ -141,7 +141,7 @@ static int k3_chipinfo_probe(struct platform_device *pdev)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
+       regmap = devm_regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
        if (IS_ERR(regmap))
                return PTR_ERR(regmap);