]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtw89: fw: correct content of DACK H2C command
authorPing-Ke Shih <pkshih@realtek.com>
Fri, 23 Jan 2026 01:39:52 +0000 (09:39 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Wed, 28 Jan 2026 03:17:18 +0000 (11:17 +0800)
The fields of command should be u8 instead of __le32. However, current
firmware doesn't really use the data for now, so this mistake doesn't
impact performance.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20260123013957.16418-7-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/fw.c
drivers/net/wireless/realtek/rtw89/fw.h

index 4035ec8defa863c9869767892768501c24426f37..8a33a63619d5a3f7852b663d0c1e663161d5c0b3 100644 (file)
@@ -7503,9 +7503,9 @@ int rtw89_fw_h2c_rf_dack(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy_idx,
        skb_put(skb, len);
        h2c = (struct rtw89_h2c_rf_dack *)skb->data;
 
-       h2c->len = cpu_to_le32(len);
-       h2c->phy = cpu_to_le32(phy_idx);
-       h2c->type = cpu_to_le32(0);
+       h2c->len = len;
+       h2c->phy = phy_idx;
+       h2c->type = 0;
 
        rtw89_h2c_pkt_set_hdr(rtwdev, skb, FWCMD_TYPE_H2C,
                              H2C_CAT_OUTSRC, H2C_CL_OUTSRC_RF_FW_RFK,
index e4dbcd899ddbabb4089a6757f239e3e1da671a31..da802482c47d283034d6dedefd3a7e337abde1f8 100644 (file)
@@ -4912,9 +4912,9 @@ struct rtw89_h2c_rf_txgapk {
 } __packed;
 
 struct rtw89_h2c_rf_dack {
-       __le32 len;
-       __le32 phy;
-       __le32 type;
+       u8 len;
+       u8 phy;
+       u8 type;
 } __packed;
 
 struct rtw89_h2c_rf_rxdck_v0 {