]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: pistachio: Constify static 'pinctrl_desc'
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 11 Jun 2025 06:13:47 +0000 (08:13 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 18 Jun 2025 11:26:37 +0000 (13:26 +0200)
The local static 'struct pinctrl_desc' is not modified, so can be made
const for code safety after moving .pins and .npins assignment to
definition.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/20250611-pinctrl-const-desc-v2-15-b11c1d650384@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-pistachio.c

index e7bf609609617d6af2f10a3df56c62e3bfe2dcd3..7f8b562c81c9cfd1ac3a0bd50018857450bdf609 100644 (file)
@@ -1156,11 +1156,14 @@ static const struct pinconf_ops pistachio_pinconf_ops = {
        .is_generic = true,
 };
 
-static struct pinctrl_desc pistachio_pinctrl_desc = {
+static const struct pinctrl_desc pistachio_pinctrl_desc = {
        .name = "pistachio-pinctrl",
        .pctlops = &pistachio_pinctrl_ops,
        .pmxops = &pistachio_pinmux_ops,
        .confops = &pistachio_pinconf_ops,
+       .pins = pistachio_pins,
+       .npins = ARRAY_SIZE(pistachio_pins),
+
 };
 
 static int pistachio_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
@@ -1474,9 +1477,6 @@ static int pistachio_pinctrl_probe(struct platform_device *pdev)
        pctl->gpio_banks = pistachio_gpio_banks;
        pctl->nbanks = ARRAY_SIZE(pistachio_gpio_banks);
 
-       pistachio_pinctrl_desc.pins = pctl->pins;
-       pistachio_pinctrl_desc.npins = pctl->npins;
-
        pctl->pctldev = devm_pinctrl_register(&pdev->dev, &pistachio_pinctrl_desc,
                                              pctl);
        if (IS_ERR(pctl->pctldev)) {