]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: hns3: using the num_tqps to check whether tqp_index is out of range when vf...
authorJian Shen <shenjian15@huawei.com>
Thu, 11 Dec 2025 02:37:36 +0000 (10:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:09:45 +0000 (13:09 +0100)
[ Upstream commit d180c11aa8a6fa735f9ac2c72c61364a9afc2ba7 ]

Currently, rss_size = num_tqps / tc_num. If tc_num is 1, then num_tqps
equals rss_size. However, if the tc_num is greater than 1, then rss_size
will be less than num_tqps, causing the tqp_index check for subsequent TCs
using rss_size to always fail.

This patch uses the num_tqps to check whether tqp_index is out of range,
instead of rss_size.

Fixes: 326334aad024 ("net: hns3: add a check for tqp_index in hclge_get_ring_chain_from_mbx()")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251211023737.2327018-3-shaojijie@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

index e2cd0eb124bac7e7c59f7c234b9a675c352fed94..f1823dd4473f75444a3a0ba52dfbb7bd755fe376 100644 (file)
@@ -187,10 +187,10 @@ static int hclge_get_ring_chain_from_mbx(
                return -EINVAL;
 
        for (i = 0; i < ring_num; i++) {
-               if (req->msg.param[i].tqp_index >= vport->nic.kinfo.rss_size) {
+               if (req->msg.param[i].tqp_index >= vport->nic.kinfo.num_tqps) {
                        dev_err(&hdev->pdev->dev, "tqp index(%u) is out of range(0-%u)\n",
                                req->msg.param[i].tqp_index,
-                               vport->nic.kinfo.rss_size - 1U);
+                               vport->nic.kinfo.num_tqps - 1U);
                        return -EINVAL;
                }
        }