vala: Do not allow to change .length of arrays with fixed length

This would result in invalid C code.

diff --git a/tests/arrays/fixed-length-read-only-length.test b/tests/arrays/fixed-length-read-only-length.test
new file mode 100644 (file)
index 0000000..b53eb11
--- /dev/null
+++ b/tests/arrays/fixed-length-read-only-length.test
@@ -0,0 +1,6 @@
+Invalid Code
+
+void main () {
+       int foo[2] = { 23, 42 };
+       foo.length = 3;
+}

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index c2ac1a1890a8c01081fc0a04628155af79d49b41..a19228dbe43d996df0d1480ae8b85b7424c5a2f7 100644 (file)
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -290,6 +290,10 @@ public class Vala.Assignment : Expression {
                                                return false;
                                        }
                                }
+                       } else if (ma.symbol_reference is ArrayLengthField && ((ArrayType) ma.inner.value_type).inline_allocated) {
+                               error = true;
+                               Report.error (source_reference, "`length' field of fixed length arrays is read-only");
+                               return false;
                        } else if (ma.symbol_reference is Variable && right.value_type == null) {
                                unowned Variable variable = (Variable) ma.symbol_reference;