]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#3344] Fix origin type in notify cmd
authorMarcin Siodelski <marcin@isc.org>
Thu, 25 Apr 2024 11:48:51 +0000 (13:48 +0200)
committerMarcin Siodelski <marcin@isc.org>
Fri, 26 Apr 2024 11:39:03 +0000 (13:39 +0200)
src/hooks/dhcp/high_availability/command_creator.cc
src/hooks/dhcp/high_availability/tests/command_creator_unittest.cc

index 6f737641410a47c3e75df7ba27282a6d3f1531bd..f3b572090ae717f102eab7ba8f341c18b3651e72 100644 (file)
@@ -267,8 +267,8 @@ CommandCreator::createSyncCompleteNotify(const unsigned int origin_id,
     auto args = Element::createMap();
     args->set("server-name", Element::create(server_name));
     args->set("origin-id", Element::create(origin_id));
-    // Add for backward compatibility with Kea 2.4.0 and earlier.
-    args->set("origin", Element::create("ha-partner"));
+    // Add for backward compatibility with Kea 2.5.5.
+    args->set("origin", Element::create(origin_id));
     auto command = config::createCommand("ha-sync-complete-notify", args);
     insertService(command, server_type);
     return (command);
index 99f935fc4beb7cd8ad764c6981894eec3872886e..084bb191666b289c44c426cc1afa28defefca760 100644 (file)
@@ -564,6 +564,10 @@ TEST(CommandCreatorTest, createSyncCompleteNotify4) {
     ASSERT_TRUE(origin_id);
     EXPECT_EQ(Element::integer, origin_id->getType());
     EXPECT_EQ(1, origin_id->intValue());
+    auto origin = arguments->get("origin");
+    ASSERT_TRUE(origin);
+    EXPECT_EQ(Element::integer, origin->getType());
+    EXPECT_EQ(1, origin->intValue());
 }
 
 // This test verifies that the ha-sync-complete-notify command sent to a
@@ -580,6 +584,10 @@ TEST(CommandCreatorTest, createSyncCompleteNotify6) {
     ASSERT_TRUE(origin_id);
     EXPECT_EQ(Element::integer, origin_id->getType());
     EXPECT_EQ(1, origin_id->intValue());
+    auto origin = arguments->get("origin");
+    ASSERT_TRUE(origin);
+    EXPECT_EQ(Element::integer, origin->getType());
+    EXPECT_EQ(1, origin->intValue());
 }
 
 }