]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: ccs: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:03:25 +0000 (21:03 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 8 Jan 2026 20:36:51 +0000 (21:36 +0100)
Passing the pm_runtime_put() return value to callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update ccs_post_streamoff() to simply discard the return
value of pm_runtime_put() and always return success to the caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://patch.msgid.link/22966634.EfDdHjke4D@rafael.j.wysocki
drivers/media/i2c/ccs/ccs-core.c

index f8523140784c7120eaf018ffa9e3b43ea12ef72f..0d7b922fd4c484398ff747f122120c8c4e0c5357 100644 (file)
@@ -1974,7 +1974,9 @@ static int ccs_post_streamoff(struct v4l2_subdev *subdev)
        struct ccs_sensor *sensor = to_ccs_sensor(subdev);
        struct i2c_client *client = v4l2_get_subdevdata(&sensor->src->sd);
 
-       return pm_runtime_put(&client->dev);
+       pm_runtime_put(&client->dev);
+
+       return 0;
 }
 
 static int ccs_enum_mbus_code(struct v4l2_subdev *subdev,