Fixed a bug where the long descriptions of bugs had a variety of

newline characters at the end, depending on the operating system of
the browser that submitted the text.

diff --git a/globals.pl b/globals.pl
index d6e18d225291d591cf639c76a0a96465ae415460..26539107bbf4a264fffab20c4fc8984bc6ee2506 100644 (file)
--- a/globals.pl
+++ b/globals.pl
@@ -78,7 +78,13 @@ sub FetchOneColumn {
 
 sub AppendComment {
     my ($bugid,$who,$comment) = (@_);
-    $comment =~ s/\r\n/\n/;     # Get rid of windows-style line endings.
+    open(DEBUG, ">/tmp/debug");
+    print DEBUG "A $comment";
+    $comment =~ s/\r\n/\n/g;     # Get rid of windows-style line endings.
+    print DEBUG "B $comment";
+    $comment =~ s/\r/\n/g;       # Get rid of mac-style line endings.
+    print DEBUG "C $comment";
+    close DEBUG;
     if ($comment =~ /^\s*$/) {  # Nothin' but whitespace.
         return;
     }

diff --git a/post_bug.cgi b/post_bug.cgi
index 1cff52326971f62a05270939c220ad594598b4e1..c0102fdbf23602fba65b47b9e480a1500a8aeca2 100755 (executable)
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -105,7 +105,12 @@ foreach my $field (@bug_fields) {
     $query .= SqlQuote($::FORM{$field}) . ",\n";
 }
 
-$query .= "now(), " . SqlQuote($::FORM{'comment'}) . " )\n";
+my $comment = $::FORM{'comment'};
+$comment =~ s/\r\n/\n/g;     # Get rid of windows-style line endings.
+$comment =~ s/\r/\n/g;       # Get rid of mac-style line endings.
+$comment = trim($comment);
+
+$query .= "now(), " . SqlQuote($comment) . " )\n";
 
 
 my %ccids;