]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
fix: reset all OffCanvas properties when in in-canvas mode 11141/head
authorNicolas Coden <nicolas@ncoden.fr>
Wed, 11 Apr 2018 20:10:39 +0000 (22:10 +0200)
committerNicolas Coden <nicolas@ncoden.fr>
Wed, 11 Apr 2018 20:10:39 +0000 (22:10 +0200)
> Done some research. The incanvas feature always used `inherit`, without explicit reasons given. Most font properties should inherit but not `background`, `width`, `overflow`, `transition` as this is not their default value. I'll replace all of them.

See https://github.com/zurb/foundation-sites/pull/11141#discussion_r180879166

scss/components/_off-canvas.scss

index bbee8cb27fbb3d9d0814726130f87aa517a232a6..120976517d83d4b34f95dad80c0a57eabed44746 100644 (file)
@@ -416,10 +416,10 @@ $breakpoint: small
   visibility: visible;
   height: auto;
   position: static;
-  background: inherit;
+  background: none;
   width: auto;
-  overflow: inherit;
-  transition: inherit;
+  overflow: visible;
+  transition: none;
 
   // Increase CSS specificity
   &.position-left,