]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: ab8500: Use resource managed API to simplify code
authorPeng Fan <peng.fan@nxp.com>
Wed, 5 Feb 2025 00:58:23 +0000 (08:58 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 3 Mar 2025 21:52:29 +0000 (22:52 +0100)
Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the
error handling code and 'driver.remove()' hook.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20250205-rtc-cleanup-v1-5-66165678e089@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ab8500.c

index 2dcda96f4a8ef727514c751322b84d8d2b382b75..ed2b6b8bb3bf8f99fef9f8bee9676f71f8a86d2a 100644 (file)
@@ -361,7 +361,7 @@ static int ab8500_rtc_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       device_init_wakeup(&pdev->dev, true);
+       devm_device_init_wakeup(&pdev->dev);
 
        rtc = devm_rtc_allocate_device(&pdev->dev);
        if (IS_ERR(rtc))
@@ -375,7 +375,7 @@ static int ab8500_rtc_probe(struct platform_device *pdev)
        if (err < 0)
                return err;
 
-       dev_pm_set_wake_irq(&pdev->dev, irq);
+       devm_pm_set_wake_irq(&pdev->dev, irq);
        platform_set_drvdata(pdev, rtc);
 
        set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features);
@@ -392,18 +392,11 @@ static int ab8500_rtc_probe(struct platform_device *pdev)
        return devm_rtc_register_device(rtc);
 }
 
-static void ab8500_rtc_remove(struct platform_device *pdev)
-{
-       dev_pm_clear_wake_irq(&pdev->dev);
-       device_init_wakeup(&pdev->dev, false);
-}
-
 static struct platform_driver ab8500_rtc_driver = {
        .driver = {
                .name = "ab8500-rtc",
        },
        .probe  = ab8500_rtc_probe,
-       .remove = ab8500_rtc_remove,
        .id_table = ab85xx_rtc_ids,
 };