]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
xfs: remove some EXPERIMENTAL warnings
authorDarrick J. Wong <djwong@kernel.org>
Tue, 13 May 2025 14:35:29 +0000 (07:35 -0700)
committerCarlos Maiolino <cem@kernel.org>
Wed, 14 May 2025 10:42:05 +0000 (12:42 +0200)
Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
syscall and parent pointers were merged in the same cycle.  None of
these have encountered any serious errors in the year that they've been
in the kernel (or the many many years they've been under development) so
let's drop the shouty warnings.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/scrub/scrub.c
fs/xfs/xfs_message.c
fs/xfs/xfs_message.h
fs/xfs/xfs_mount.h
fs/xfs/xfs_super.c

index 9908850bf76f9e20076231d27a5fa85d07d34ba0..76e24032e99a531e71d97b72fe63c780d93d0768 100644 (file)
@@ -680,8 +680,6 @@ xfs_scrub_metadata(
        if (error)
                goto out;
 
-       xfs_warn_experimental(mp, XFS_EXPERIMENTAL_SCRUB);
-
        sc = kzalloc(sizeof(struct xfs_scrub), XCHK_GFP_FLAGS);
        if (!sc) {
                error = -ENOMEM;
index 15d410d16bb27c62e338e86d6c87d4bc2229ee86..54fc5ada519c4315084925def2ad2d51f5e497d1 100644 (file)
@@ -145,10 +145,6 @@ xfs_warn_experimental(
                        .opstate        = XFS_OPSTATE_WARNED_PNFS,
                        .name           = "pNFS",
                },
-               [XFS_EXPERIMENTAL_SCRUB] = {
-                       .opstate        = XFS_OPSTATE_WARNED_SCRUB,
-                       .name           = "online scrub",
-               },
                [XFS_EXPERIMENTAL_SHRINK] = {
                        .opstate        = XFS_OPSTATE_WARNED_SHRINK,
                        .name           = "online shrink",
@@ -161,14 +157,6 @@ xfs_warn_experimental(
                        .opstate        = XFS_OPSTATE_WARNED_LBS,
                        .name           = "large block size",
                },
-               [XFS_EXPERIMENTAL_EXCHRANGE] = {
-                       .opstate        = XFS_OPSTATE_WARNED_EXCHRANGE,
-                       .name           = "exchange range",
-               },
-               [XFS_EXPERIMENTAL_PPTR] = {
-                       .opstate        = XFS_OPSTATE_WARNED_PPTR,
-                       .name           = "parent pointer",
-               },
                [XFS_EXPERIMENTAL_METADIR] = {
                        .opstate        = XFS_OPSTATE_WARNED_METADIR,
                        .name           = "metadata directory tree",
index a92a4d09c8e9fa0b129400bcbfda3e10afcfff0b..bce9942f394a6f86c4038b4086f3528efdceb3eb 100644 (file)
@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
 
 enum xfs_experimental_feat {
        XFS_EXPERIMENTAL_PNFS,
-       XFS_EXPERIMENTAL_SCRUB,
        XFS_EXPERIMENTAL_SHRINK,
        XFS_EXPERIMENTAL_LARP,
        XFS_EXPERIMENTAL_LBS,
-       XFS_EXPERIMENTAL_EXCHRANGE,
-       XFS_EXPERIMENTAL_PPTR,
        XFS_EXPERIMENTAL_METADIR,
        XFS_EXPERIMENTAL_ZONED,
 
index 5b5df70570c0db88c1a404df28118bace5a12d59..168b4d340cfc81ff79dce4187cc22d3bb4aee647 100644 (file)
@@ -559,8 +559,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
 
 /* Kernel has logged a warning about pNFS being used on this fs. */
 #define XFS_OPSTATE_WARNED_PNFS                7
-/* Kernel has logged a warning about online fsck being used on this fs. */
-#define XFS_OPSTATE_WARNED_SCRUB       8
 /* Kernel has logged a warning about shrink being used on this fs. */
 #define XFS_OPSTATE_WARNED_SHRINK      9
 /* Kernel has logged a warning about logged xattr updates being used. */
@@ -573,10 +571,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
 #define XFS_OPSTATE_USE_LARP           13
 /* Kernel has logged a warning about blocksize > pagesize on this fs. */
 #define XFS_OPSTATE_WARNED_LBS         14
-/* Kernel has logged a warning about exchange-range being used on this fs. */
-#define XFS_OPSTATE_WARNED_EXCHRANGE   15
-/* Kernel has logged a warning about parent pointers being used on this fs. */
-#define XFS_OPSTATE_WARNED_PPTR                16
 /* Kernel has logged a warning about metadata dirs being used on this fs. */
 #define XFS_OPSTATE_WARNED_METADIR     17
 /* Filesystem should use qflags to determine quotaon status */
@@ -645,7 +639,6 @@ xfs_should_warn(struct xfs_mount *mp, long nr)
        { (1UL << XFS_OPSTATE_READONLY),                "read_only" }, \
        { (1UL << XFS_OPSTATE_INODEGC_ENABLED),         "inodegc" }, \
        { (1UL << XFS_OPSTATE_BLOCKGC_ENABLED),         "blockgc" }, \
-       { (1UL << XFS_OPSTATE_WARNED_SCRUB),            "wscrub" }, \
        { (1UL << XFS_OPSTATE_WARNED_SHRINK),           "wshrink" }, \
        { (1UL << XFS_OPSTATE_WARNED_LARP),             "wlarp" }, \
        { (1UL << XFS_OPSTATE_QUOTACHECK_RUNNING),      "quotacheck" }, \
index 8e3ae1749855adcbb0a1c04de9a0aeb15a1ae135..5318ab438054cc172fff43949fd9af78f7b88a03 100644 (file)
@@ -1954,13 +1954,6 @@ xfs_fs_fill_super(
                }
        }
 
-
-       if (xfs_has_exchange_range(mp))
-               xfs_warn_experimental(mp, XFS_EXPERIMENTAL_EXCHRANGE);
-
-       if (xfs_has_parent(mp))
-               xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PPTR);
-
        /*
         * If no quota mount options were provided, maybe we'll try to pick
         * up the quota accounting and enforcement flags from the ondisk sb.