MINOR: backend: Do not always allow takeover across thread groups

Instead of silently ignoring tune.idle-pool.shared. full
if tune.fd.tables per-thread-group is set, have an error at startup if
both are set, as they are incompatible.

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 48edfae62467c87fc44127d102aa7b49d7859be3..ee86a7b5ae390a8686a67978f908743a1556c232 100644 (file)
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -2344,6 +2344,12 @@ int check_config_validity()
                goto out;
        }
 
+       if ((global.tune.tg_takeover == FULL_THREADGROUP_TAKEOVER) &&
+           (global.tune.options & GTUNE_NO_TG_FD_SHARING)) {
+               err_code |= ERR_FATAL | ERR_ALERT;
+               ha_alert("tune.fd.tables per-thread-group is incompatible with tune.idle-pool shared full\n");
+               goto out;
+       }
        pool_head_requri = create_pool("requri", global.tune.requri_len , MEM_F_SHARED);
 
        pool_head_capture = create_pool("capture", global.tune.cookie_len, MEM_F_SHARED);