]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: rme32: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:07:00 +0000 (12:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:22 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-79-tiwai@suse.de
sound/pci/rme32.c

index 4bf122abea4871a682135ab4291eadad97c3d0b9..f07b6023473a06b7450feaf27b7d400579e70133 100644 (file)
@@ -1314,7 +1314,7 @@ static int snd_rme32_create(struct rme32 *rme32)
                return err;
        rme32->spdif_pcm->private_data = rme32;
        rme32->spdif_pcm->private_free = snd_rme32_free_spdif_pcm;
-       strcpy(rme32->spdif_pcm->name, "Digi32 IEC958");
+       strscpy(rme32->spdif_pcm->name, "Digi32 IEC958");
        if (rme32->fullduplex_mode) {
                snd_pcm_set_ops(rme32->spdif_pcm, SNDRV_PCM_STREAM_PLAYBACK,
                                &snd_rme32_playback_spdif_fd_ops);
@@ -1344,7 +1344,7 @@ static int snd_rme32_create(struct rme32 *rme32)
                        return err;
                rme32->adat_pcm->private_data = rme32;
                rme32->adat_pcm->private_free = snd_rme32_free_adat_pcm;
-               strcpy(rme32->adat_pcm->name, "Digi32 ADAT");
+               strscpy(rme32->adat_pcm->name, "Digi32 ADAT");
                if (rme32->fullduplex_mode) {
                        snd_pcm_set_ops(rme32->adat_pcm, SNDRV_PCM_STREAM_PLAYBACK, 
                                        &snd_rme32_playback_adat_fd_ops);
@@ -1879,16 +1879,16 @@ __snd_rme32_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
        if (err < 0)
                return err;
 
-       strcpy(card->driver, "Digi32");
+       strscpy(card->driver, "Digi32");
        switch (rme32->pci->device) {
        case PCI_DEVICE_ID_RME_DIGI32:
-               strcpy(card->shortname, "RME Digi32");
+               strscpy(card->shortname, "RME Digi32");
                break;
        case PCI_DEVICE_ID_RME_DIGI32_8:
-               strcpy(card->shortname, "RME Digi32/8");
+               strscpy(card->shortname, "RME Digi32/8");
                break;
        case PCI_DEVICE_ID_RME_DIGI32_PRO:
-               strcpy(card->shortname, "RME Digi32 PRO");
+               strscpy(card->shortname, "RME Digi32 PRO");
                break;
        }
        sprintf(card->longname, "%s (Rev. %d) at 0x%lx, irq %d",