]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
leds: lp8860: Remove unused read of STATUS register
authorAndrew Davis <afd@ti.com>
Thu, 5 Mar 2026 20:37:05 +0000 (14:37 -0600)
committerLee Jones <lee@kernel.org>
Tue, 10 Mar 2026 09:23:12 +0000 (09:23 +0000)
This register is read but the contents are never checked, remove
the read until we add status checking. While here add an error
message should the preceding fault check fail.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20260305203706.841384-4-afd@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-lp8860.c

index 16129ae94d65fc0b6f0469a0d199df9805d6ff90..6d1c9434e6d174eb855f32039088f6297d9f87ae 100644 (file)
@@ -185,18 +185,15 @@ static int lp8860_brightness_set(struct led_classdev *led_cdev,
 
 static int lp8860_program_eeprom(struct lp8860_led *led)
 {
-       unsigned int read_buf;
        int ret, reg_count;
 
        guard(mutex)(&led->lock);
 
        ret = lp8860_fault_check(led);
-       if (ret)
-               return ret;
-
-       ret = regmap_read(led->regmap, LP8860_STATUS, &read_buf);
-       if (ret)
+       if (ret) {
+               dev_err(&led->client->dev, "Cannot read/clear faults\n");
                return ret;
+       }
 
        ret = regmap_write(led->regmap, LP8860_EEPROM_UNLOCK, LP8860_EEPROM_CODE_1);
        if (ret) {