libcli/security: remove redundant claim SID size check

blob_string_sid_to_sid() immediately checks the size is within 5-191, so the 1-10000
just gives you a different message in chircumstances you'll never see.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/security/claims-conversions.c b/libcli/security/claims-conversions.c
index 935c5eedfd8572ef5bcb560667a0a69305b18e60..85206511883ca573777f51120b3b1c7b6d1e0024 100644 (file)
--- a/libcli/security/claims-conversions.c
+++ b/libcli/security/claims-conversions.c
@@ -163,13 +163,6 @@ static bool claim_v1_sid_to_ace_sid(
 
        v = claim->values[offset].sid_value;
 
-       if (v->length == 0 || v->length > CONDITIONAL_ACE_MAX_LENGTH) {
-               DBG_WARNING("claim has SID string of unexpected length %zu, "
-                           "(expected range 1 - %u)\n",
-                           v->length, CONDITIONAL_ACE_MAX_LENGTH);
-               return false;
-       }
-
        ok = blob_string_sid_to_sid(v, &result->data.sid.sid);
        if (! ok) {
                DBG_WARNING("claim has invalid SID string of length %zu.\n",