media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()

The num_clks is set this way:

	hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
        if (hdmirx_dev->num_clks < 1)
                return -ENODEV;

The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.

Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index e4cdd8b5745de9b8d789370f200efc1dd76a34bd..3d2913de9a86c6a4e66562727388b4326365048a 100644 (file)
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -151,7 +151,7 @@ struct snps_hdmirx_dev {
        bool hpd_trigger_level_high;
        bool tmds_clk_ratio;
        bool plugged;
-       u32 num_clks;
+       int num_clks;
        u32 edid_blocks_written;
        u32 cur_fmt_fourcc;
        u32 color_depth;