]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dmaengine: ioat: Allocate correct size for descriptor chunk
authorLogan Gunthorpe <logang@deltatee.com>
Tue, 22 Sep 2020 20:08:44 +0000 (14:08 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:07:49 +0000 (10:07 +0100)
[ Upstream commit 028926e4ac8f21af343c25794117fd13c08b1712 ]

dma_alloc_coherent() is called with a fixed SZ_2M size, but frees happen
with IOAT_CHUNK_SIZE. Recently, IOAT_CHUNK_SIZE was reduced to 512M but
the allocation did not change. To fix, change to using the
IOAT_CHUNK_SIZE define.

This was caught with the upcoming patchset for converting Intel platforms to the
dma-iommu implementation. It has a warning when the unmapped size differs from
the mapped size.

Fixes: a02254f8a676 ("dmaengine: ioat: Decreasing allocation chunk size 2M->512K")
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/intel-gfx/776771a2-247a-d1be-d882-bee02d919ae0@deltatee.com/
Link: https://lore.kernel.org/r/20200922200844.2982-1-logang@deltatee.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/ioat/dma.c

index fd782aee02d92d27626e6a87494e78bc6fe956a5..98c56606ab1a9dd6e1f8bdbf5c08f487f00c318a 100644 (file)
@@ -389,7 +389,7 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags)
                struct ioat_descs *descs = &ioat_chan->descs[i];
 
                descs->virt = dma_alloc_coherent(to_dev(ioat_chan),
-                                                SZ_2M, &descs->hw, flags);
+                                       IOAT_CHUNK_SIZE, &descs->hw, flags);
                if (!descs->virt) {
                        int idx;