]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBuildMemoryCellBackendStr: remove useless ret variable
authorJán Tomko <jtomko@redhat.com>
Mon, 26 Aug 2019 20:38:51 +0000 (22:38 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 18 Sep 2019 09:33:18 +0000 (11:33 +0200)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
src/qemu/qemu_command.c

index df499f75e3d68e28bd0998bd895ed002933eee8b..90e090c72ea96b2e386c1a9175c469edf8ee5403 100644 (file)
@@ -3590,14 +3590,13 @@ qemuBuildMemoryCellBackendStr(virDomainDefPtr def,
 {
     VIR_AUTOPTR(virJSONValue) props = NULL;
     VIR_AUTOFREE(char *) alias = NULL;
-    int ret = -1;
     int rc;
     virDomainMemoryDef mem = { 0 };
     unsigned long long memsize = virDomainNumaGetNodeMemorySize(def->numa,
                                                                 cell);
 
     if (virAsprintf(&alias, "ram-node%zu", cell) < 0)
-        goto cleanup;
+        return -1;
 
     mem.size = memsize;
     mem.targetNode = cell;
@@ -3605,16 +3604,12 @@ qemuBuildMemoryCellBackendStr(virDomainDefPtr def,
 
     if ((rc = qemuBuildMemoryBackendProps(&props, alias, cfg,
                                           priv, def, &mem, false)) < 0)
-        goto cleanup;
+        return -1;
 
     if (virQEMUBuildObjectCommandlineFromJSON(buf, props) < 0)
-        goto cleanup;
-
-    ret = rc;
-
- cleanup:
+        return -1;
 
-    return ret;
+    return rc;
 }