]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
wrapper.c: null terminate string in cgroup_new_cgroup()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Wed, 20 Jul 2022 17:10:52 +0000 (11:10 -0600)
committerTom Hromatka <tom.hromatka@oracle.com>
Wed, 20 Jul 2022 17:10:56 +0000 (11:10 -0600)
Fix non-terminated string warning, reported by Coverity tool:

CID 258290 (#1 of 1): String not null terminated (STRING_NULL)46.
string_null: Passing unterminated string aux_cgroup->name to
cgroup_create_cgroup, which expects a null-terminated string.

The call patch leading to this warning:
config.c::cgroup_config_create_template_group()
- wrapper.c::cgroup_new_cgroup()

fix it by null terminating the string.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit 239b3c4154e8129b62db0f1743f3e947e6932871)

src/wrapper.c

index 7dac475b88b24d0cbd1e6e1062604b09a1d51a65..965430f6cc7bb17804e91719c40d9ccc3c1d15bb 100644 (file)
@@ -48,7 +48,8 @@ struct cgroup *cgroup_new_cgroup(const char *name)
                return NULL;
 
        init_cgroup(cgroup);
-       strncpy(cgroup->name, name, sizeof(cgroup->name) - 1);
+       strncpy(cgroup->name, name, FILENAME_MAX - 1);
+       cgroup->name[FILENAME_MAX - 1] = '\0';
 
        return cgroup;
 }