]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Change virNWFilterObjDeleteDef to virNWFilterDeleteDef
authorJohn Ferlan <jferlan@redhat.com>
Tue, 28 Feb 2017 22:25:36 +0000 (17:25 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Tue, 7 Mar 2017 18:27:25 +0000 (13:27 -0500)
Rather than pass the nwfilter object, just pass the def to the function

src/conf/nwfilter_conf.c
src/conf/nwfilter_conf.h
src/libvirt_private.syms
src/nwfilter/nwfilter_driver.c

index 855fec78bb86adcf646c8fbd2ed75236ddcddae5..f5290810b70bda0bc736de38204f6cdc56d1002a 100644 (file)
@@ -3263,21 +3263,19 @@ virNWFilterSaveDef(const char *configDir,
 
 
 int
-virNWFilterObjDeleteDef(const char *configDir,
-                        virNWFilterObjPtr nwfilter)
+virNWFilterDeleteDef(const char *configDir,
+                     virNWFilterDefPtr def)
 {
     int ret = -1;
     char *configFile = NULL;
 
-    if (!(configFile = virFileBuildPath(configDir,
-                                        nwfilter->def->name, ".xml"))) {
+    if (!(configFile = virFileBuildPath(configDir, def->name, ".xml")))
         goto error;
-    }
 
     if (unlink(configFile) < 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("cannot remove config for %s"),
-                       nwfilter->def->name);
+                       def->name);
         goto error;
     }
 
index 2211c2aa726ec9d867b62ae501749e4bb16f447b..d87da0c6b8ec917126be0c922c43aa308fe79c31 100644 (file)
@@ -614,8 +614,8 @@ virNWFilterObjPtr virNWFilterObjFindByName(virNWFilterObjListPtr nwfilters,
 int virNWFilterSaveDef(const char *configDir,
                        virNWFilterDefPtr def);
 
-int virNWFilterObjDeleteDef(const char *configDir,
-                            virNWFilterObjPtr nwfilter);
+int virNWFilterDeleteDef(const char *configDir,
+                         virNWFilterDefPtr def);
 
 virNWFilterObjPtr virNWFilterObjAssignDef(virNWFilterObjListPtr nwfilters,
                                           virNWFilterDefPtr def);
index b4553a90e82b44b8b3ac9a07a86d9b528235d5be..0c6ea2b58d9276b3de4a3c350f07bd9b5a467ad2 100644 (file)
@@ -743,11 +743,11 @@ virNWFilterDefFormat;
 virNWFilterDefFree;
 virNWFilterDefParseFile;
 virNWFilterDefParseString;
+virNWFilterDeleteDef;
 virNWFilterInstFiltersOnAllVMs;
 virNWFilterJumpTargetTypeToString;
 virNWFilterLoadAllConfigs;
 virNWFilterObjAssignDef;
-virNWFilterObjDeleteDef;
 virNWFilterObjFindByName;
 virNWFilterObjFindByUUID;
 virNWFilterObjListFree;
index fe5fa548fb2cae1c9ae8944df289fa6ad56b4422..5e4f07655c32f332e5aec5b8c86f17d16c5ab806 100644 (file)
@@ -603,7 +603,7 @@ nwfilterUndefine(virNWFilterPtr obj)
         goto cleanup;
     }
 
-    if (virNWFilterObjDeleteDef(driver->configDir, nwfilter) < 0)
+    if (virNWFilterDeleteDef(driver->configDir, nwfilter->def) < 0)
         goto cleanup;
 
     virNWFilterObjRemove(&driver->nwfilters, nwfilter);