tcpiohandler: Fix performance inefficiency reported by Coverity

CID 501583 and 501584

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/tcpiohandler.cc b/pdns/tcpiohandler.cc
index 857b690b1dfd190f060a0ff707fe931c61c6b083..7ee5cfbaa05a410c19532a46ded828d865d7cf0a 100644 (file)
--- a/pdns/tcpiohandler.cc
+++ b/pdns/tcpiohandler.cc
@@ -866,7 +866,7 @@ public:
       if (!params.d_client_certificate_password.empty()) {
         password = params.d_client_certificate_password;
       }
-      TLSCertKeyPair pair{params.d_client_certificate, key, password};
+      TLSCertKeyPair pair{params.d_client_certificate, std::move(key), std::move(password)};
       std::vector<int> keyTypes;
       libssl_setup_context_no_sni(d_tlsCtx.get(), pair, keyTypes);
     }