]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: quic: remove obsolete comment on send
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 10 Jul 2024 08:53:39 +0000 (10:53 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 11 Jul 2024 09:02:44 +0000 (11:02 +0200)
Remove comment on send which is now obsolete since the introduction of
per-connection socket.

src/quic_tx.c

index 8900d4f348153fefaa83ac7b29bacd2c96cc9376..bff49ac4ce7ef4e3e75b845c7fdc38ac1169ca42 100644 (file)
@@ -299,16 +299,6 @@ static int qc_send_ppkts(struct buffer *buf, struct ssl_sock_ctx *ctx)
                tmpbuf.size = tmpbuf.data = dglen;
 
                TRACE_PROTO("TX dgram", QUIC_EV_CONN_SPPKTS, qc);
-               /* If sendto is on error just skip the call to it for the rest
-                * of the loop but continue to purge the buffer. Data will be
-                * transmitted when QUIC packets are detected as lost on our
-                * side.
-                *
-                * TODO use fd-monitoring to detect when send operation can be
-                * retry. This should improve the bandwidth without relying on
-                * retransmission timer. However, it requires a major rework on
-                * quic-conn fd management.
-                */
                if (!skip_sendto) {
                        int ret = qc_snd_buf(qc, &tmpbuf, tmpbuf.data, 0);
                        if (ret < 0) {