Avoid passing a constant to atoi

Use strtol only if server_port is null rather than waste time putting "0" in atoi, which always comes out as 0

diff --git a/cgi-bin/admin.c b/cgi-bin/admin.c
index 37f93b5d51661162fe192822770e94ce31057bec..626afaa7bcb2093ac4ff3ccb8121ba92af99b51b 100644 (file)
--- a/cgi-bin/admin.c
+++ b/cgi-bin/admin.c
@@ -119,7 +119,7 @@ main(void)
                                        /* Printer or class name */
                *server_port = getenv("SERVER_PORT");
                                        /* Port number string */
-      int      port = atoi(server_port ? server_port : "0");
+      int      port = server_port ? atoi(server_port) : 0;
                                        /* Port number */
       char     uri[1024];              /* URL */
 
@@ -867,7 +867,7 @@ do_am_printer(http_t *http,         /* I - HTTP connection */
     else
       maxrate = 19200;
 
-    for (i = 0; i < 10; i ++)
+    for (i = 0; i < (int)(sizeof(baudrates)/sizeof(baudrates[0])); i ++)
       if (baudrates[i] > maxrate)
         break;
       else