Check random_get_bytes() output even in testing case

Make this a bit more consistent even for CONFIG_TESTING_OPTIONS=y builds
to reduce warnings from static analyzers.

Signed-off-by: Jouni Malinen <j@w1.fi>

diff --git a/src/ap/wpa_auth.c b/src/ap/wpa_auth.c
index fdeac6278ac561888c5c5a1fa20be384ca9f89d5..80f9984cce4a1bf43ca99739b323a2efd7210223 100644 (file)
--- a/src/ap/wpa_auth.c
+++ b/src/ap/wpa_auth.c
@@ -2084,8 +2084,9 @@ void __wpa_send_eapol(struct wpa_authenticator *wpa_auth,
                os_memcpy(key->key_rsc, key_rsc, WPA_KEY_RSC_LEN);
 
 #ifdef CONFIG_TESTING_OPTIONS
-       if (conf->eapol_key_reserved_random)
-               random_get_bytes(key->key_id, sizeof(key->key_id));
+       if (conf->eapol_key_reserved_random &&
+           random_get_bytes(key->key_id, sizeof(key->key_id)) < 0)
+               os_memset(key->key_id, 0x11, sizeof(key->key_id));
 #endif /* CONFIG_TESTING_OPTIONS */
 
        if (kde && !encr) {