Bug 778674: Throw an error in Product.get() if required params are not passed

r/a=LpSolit

diff --git a/Bugzilla/WebService/Product.pm b/Bugzilla/WebService/Product.pm
index 136870890b9a90e84388908f9427d7211f51826a..18594d7260e77b00309504637d9656e426728664 100644 (file)
--- a/Bugzilla/WebService/Product.pm
+++ b/Bugzilla/WebService/Product.pm
@@ -67,6 +67,9 @@ sub get_accessible_products {
 sub get {
     my ($self, $params) = validate(@_, 'ids', 'names');
 
+    defined $params->{ids} || defined $params->{names}
+        || ThrowCodeError("params_required", { function => "Product.get",
+                                               params => ['ids', 'names'] });
     Bugzilla->switch_to_shadow_db();
 
     # Only products that are in the users accessible products, 
@@ -363,7 +366,9 @@ B<EXPERIMENTAL>
 
 Returns a list of information about the products passed to it.
 
-Note: Can also be called as "get_products" for compatibilty with Bugzilla 3.0 API.
+B<Note>: You must at least specify one of C<ids> or C<names>.
+
+B<Note>: Can also be called as "get_products" for compatibilty with Bugzilla 3.0 API.
 
 =item B<Params>