s3:winbind: add bounds check for dom_sid_idx

Add SMB_ASSERT to verify dom_sid_idx stays within the
dom_sids/dom_xids array bounds in wb_xids2sids_dom_done().

Signed-off-by: Shweta Sodani <ssodani@redhat.com>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/source3/winbindd/wb_xids2sids.c b/source3/winbindd/wb_xids2sids.c
index 0384740d17d17bb0c04cd379dc24b614b6efdf76..88e6e4429054d435a943546a76bf9e552cc69319 100644 (file)
--- a/source3/winbindd/wb_xids2sids.c
+++ b/source3/winbindd/wb_xids2sids.c
@@ -192,6 +192,7 @@ static void wb_xids2sids_dom_done(struct tevent_req *subreq)
                        continue;
                }
 
+               SMB_ASSERT(dom_sid_idx < state->num_dom_xids);
                sid_copy(&state->all_sids[i], &state->dom_sids[dom_sid_idx]);
                *id = state->dom_xids[dom_sid_idx];
                D_DEBUG("%zu: XID %"PRIu32" mapped to SID %s.\n",