[Bug 2909] - Slow memory leak in CRYPTO_ASSOC

 - added missing call to 'free()' in ntp_crypto.c.

bk: 5609692evz8-Q9aKG_bPsoQxQrt6Wg

diff --git a/ChangeLog b/ChangeLog
index 266244bf2fd850831895852799484ab0e97c5865..9ca95350eac0b03c7c2e3d3523924006e0d860ba 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -20,6 +20,7 @@
 * [Bug 2890] Ignore ENOBUFS on routing netlink socket.  Konstantin Khlebnikov.
 * [Bug 2906] make check needs better support for pthreads.  Harlan Stenn.
 * [Bug 2907] dist* build targets require our libevent/ to be enabled.  HStenn.
+* [Bug 2909] added missing call to 'free()' in ntp_crypto.c. perlinger@ntp.org
 * libntp/emalloc.c: Remove explicit include of stdint.h.  Harlan Stenn.
 * Put Unity CPPFLAGS items in unity_config.h.  Harlan Stenn.
 * tests/ntpd/g_leapsec.cpp typo fix.  Harlan Stenn.

diff --git a/ntpd/ntp_crypto.c b/ntpd/ntp_crypto.c
index e9cd6c2036f323c9abba43128bd1d423a7c335e4..a7b693f2e5137fc056c47a247a75798e860142ca 100644 (file)
--- a/ntpd/ntp_crypto.c
+++ b/ntpd/ntp_crypto.c
@@ -508,6 +508,7 @@ crypto_recv(
                                        rval = XEVNT_ERR;
                                        break;
                                }
+                               free(peer->cmmd); /* will be set again! */
                        }
                        fp = emalloc(len);
                        memcpy(fp, ep, len);