virDomainAuthorizedSSHKeysSet: Use uint for @nkeys

When introducing the API I've mistakenly used 'int' type for
@nkeys argument which does nothing more than tells the API how
many items there are in @keys array. Obviously, negative values
are not expected and therefore 'unsigned int' should have been
used.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index d81157ccaff2c4dd4b385630237b51c13d628de8..b929877643254055af2043126f49c021133a8f5e 100644 (file)
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -5115,7 +5115,7 @@ typedef enum {
 int virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
                                   const char *user,
                                   const char **keys,
-                                  int nkeys,
+                                  unsigned int nkeys,
                                   unsigned int flags);
 
 #endif /* LIBVIRT_DOMAIN_H */

diff --git a/src/driver-hypervisor.h b/src/driver-hypervisor.h
index 5a5ea95c5156f8dfc335c8d1a10ae74fccfe6bba..9e8fe89921b57e240970f8648f52276c2504208a 100644 (file)
--- a/src/driver-hypervisor.h
+++ b/src/driver-hypervisor.h
@@ -1397,7 +1397,7 @@ typedef int
 (*virDrvDomainAuthorizedSSHKeysSet)(virDomainPtr domain,
                                     const char *user,
                                     const char **keys,
-                                    int nkeys,
+                                    unsigned int nkeys,
                                     unsigned int flags);
 
 typedef struct _virHypervisorDriver virHypervisorDriver;

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 63d4954e6840ac59c15a0a8853317a93fc5097ad..0d0041f983886dc428af50c74c7b1052bb50fe46 100644 (file)
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -12853,12 +12853,12 @@ int
 virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
                               const char *user,
                               const char **keys,
-                              int nkeys,
+                              unsigned int nkeys,
                               unsigned int flags)
 {
     virConnectPtr conn;
 
-    VIR_DOMAIN_DEBUG(domain, "user=%s, keys=%p, nkeys=%d, flags=0x%x",
+    VIR_DOMAIN_DEBUG(domain, "user=%s, keys=%p, nkeys=%u, flags=0x%x",
                      user, keys, nkeys, flags);
 
     virResetLastError();

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index b69be1bedcb4140cfe46f585c0521c2d5cc75c00..20e24e247974239cf7a476f3947cadac73699fbf 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -20134,7 +20134,7 @@ static int
 qemuDomainAuthorizedSSHKeysSet(virDomainPtr dom,
                                const char *user,
                                const char **keys,
-                               int nkeys,
+                               unsigned int nkeys,
                                unsigned int flags)
 {
     virQEMUDriverPtr driver = dom->conn->privateData;

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 6c0e7f75142352246db72b82926a92276ce4eaee..b0af3ee88ed2d8deb9a754acbdd8b1770dbe6155 100644 (file)
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -8066,7 +8066,7 @@ static int
 remoteDomainAuthorizedSSHKeysSet(virDomainPtr domain,
                                  const char *user,
                                  const char **keys,
-                                 int nkeys,
+                                 unsigned int nkeys,
                                  unsigned int flags)
 {
     int rv = -1;