cgcreate: add err check

cgroup still can be created even if giving invalid -d,-f,-s parameter
e.g.
        cgcreate -g cpu:/test -d 888
        "888" is invalid, but test will be cgreated.

        So we should exit if -d,-f or -s is invalid

v2:
 - add nonzero return value

Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com>
Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>

diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index b0003b1eb47a9c94612b8cd00398179f7f8179f8..f1920eabfff11172bd32b80b2f6ff1422adac1a0 100644 (file)
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -139,14 +139,20 @@ int main(int argc, char *argv[])
                case 'd':
                        dirm_change = 1;
                        ret = parse_mode(optarg, &dir_mode, argv[0]);
+                       if (ret)
+                               goto err;
                        break;
                case 'f':
                        filem_change = 1;
                        ret = parse_mode(optarg, &file_mode, argv[0]);
+                       if (ret)
+                               goto err;
                        break;
                case 's':
                        filem_change = 1;
                        ret = parse_mode(optarg, &tasks_mode, argv[0]);
+                       if (ret)
+                               goto err;
                        break;
                default:
                        usage(1, argv[0]);