]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
transaction inspection: fix limit enforcement
authorVictor Julien <victor@inliniac.net>
Thu, 20 Aug 2015 17:31:23 +0000 (19:31 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 20 Aug 2015 17:31:23 +0000 (19:31 +0200)
Make sure we're never wrapping around the size value.

src/detect-engine-hcbd.c
src/detect-engine-hhd.c
src/detect-engine-hsbd.c

index a1e47e6be4394967f58755cd07becf3b9e76bea8..09b7980a1c37f8fb2d7cfccba234309ce75c1009 100644 (file)
@@ -64,7 +64,7 @@
 
 static inline int HCBDCreateSpace(DetectEngineThreadCtx *det_ctx, uint64_t size)
 {
-    if (size >= USHRT_MAX)
+    if (size >= (USHRT_MAX - BUFFER_STEP))
         return -1;
 
     void *ptmp;
index baf5cf66720133f258c2f7e6587ab87a81c140a8..3bec4fd2f2eaf45965798a0859d3e91f95df88f6 100644 (file)
@@ -62,7 +62,7 @@
 
 static inline int HHDCreateSpace(DetectEngineThreadCtx *det_ctx, uint64_t size)
 {
-    if (size >= USHRT_MAX)
+    if (size >= (USHRT_MAX - BUFFER_STEP))
         return -1;
 
     void *ptmp;
index a6319db67f9842e6afabe79acac614cb65c1d828..7d52c7d8f6834105de7c76470eb09182963c630b 100644 (file)
@@ -66,7 +66,7 @@
 
 static inline int HSBDCreateSpace(DetectEngineThreadCtx *det_ctx, uint64_t size)
 {
-    if (size >= USHRT_MAX)
+    if (size >= (USHRT_MAX - BUFFER_STEP))
         return -1;
 
     void *ptmp;